Skip to content

Follow up to windows backends#505

Merged
BoboTiG merged 13 commits intoBoboTiG:mainfrom
halldorfannar:task/follow-up-to-windows-backends
Apr 22, 2026
Merged

Follow up to windows backends#505
BoboTiG merged 13 commits intoBoboTiG:mainfrom
halldorfannar:task/follow-up-to-windows-backends

Conversation

@halldorfannar
Copy link
Copy Markdown
Contributor

@halldorfannar halldorfannar commented Apr 21, 2026

Changes proposed in this PR

Address feedback from @jholveck and also some improvements to better align with backend strategy.

Also:

  • fix test_sdist (history.rst replaces changelog.rst)
  • fix .gitignore to properly exclude virtualenv
  • fix pyproject.toml so that uv is happy (need to make docs build conditional on newer python due to sphinx 0.9)
  • Tests added/updated
  • Documentation updated
  • Changelog entry added
  • ./check.sh passed

@halldorfannar halldorfannar changed the title Task/follow up to windows backends Follow up to windows backends Apr 21, 2026
Comment thread src/tests/bench_grab_windows.py
Comment thread .gitignore
Comment thread docs/source/release-history/v10.2.0.md Outdated
@halldorfannar halldorfannar marked this pull request as ready for review April 21, 2026 21:25
@BoboTiG BoboTiG requested a review from jholveck April 22, 2026 04:38
Copy link
Copy Markdown
Contributor

@jholveck jholveck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks fine as-is. I've added a couple tiny nits, but you can take them or leave them.

In src/tests/conftest.py, we do have a backend fixture that will iterate over the backends for the current platform. This can be used explicitly by a test that needs to iterate over the backends. It can also be used implicitly via the mss_impl fixture, which gives you an MSS factory, iterating over the backends. Both of these mean that tests that use those will run multiple times, once for each backend. When we do add the dxgi backend, you should fix the backend fixture accordingly.

Comment thread docs/source/release-history/v10.2.0.md Outdated
Comment thread src/mss/windows/__init__.py Outdated
@BoboTiG BoboTiG merged commit 2da8ec1 into BoboTiG:main Apr 22, 2026
21 checks passed
@BoboTiG
Copy link
Copy Markdown
Owner

BoboTiG commented Apr 22, 2026

Thanks @halldorfannar! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants